-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat meshes inspector #79
Feat meshes inspector #79
Conversation
…nspector into feat_meshes_inspector
src/geode/inspector/criterion/manifold/brep_meshes_manifold.cpp
Outdated
Show resolved
Hide resolved
include/geode/inspector/criterion/adjacency/brep_meshes_adjacency.h
Outdated
Show resolved
Hide resolved
src/geode/inspector/criterion/manifold/brep_meshes_manifold.cpp
Outdated
Show resolved
Hide resolved
include/geode/inspector/criterion/adjacency/brep_meshes_adjacency.h
Outdated
Show resolved
Hide resolved
…_meshes_inspector
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There were too many comments to post at once. Showing the first 25 out of 826. Check the log or trigger a new build to see more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There were too many comments to post at once. Showing the first 25 out of 801. Check the log or trigger a new build to see more.
@@ -37,11 +37,8 @@ namespace geode | |||
absl::StrCat( "SurfaceMeshAdjacency", dimension, "D" ); | |||
pybind11::class_< SurfaceMeshAdjacency >( module, name.c_str() ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: unexpected type name 'SurfaceMeshAdjacency': expected expression [clang-diagnostic-error]
pybind11::class_< SurfaceMeshAdjacency >( module, name.c_str() )
^
@@ -37,11 +37,8 @@ namespace geode | |||
absl::StrCat( "SurfaceMeshAdjacency", dimension, "D" ); | |||
pybind11::class_< SurfaceMeshAdjacency >( module, name.c_str() ) | |||
.def( pybind11::init< const SurfaceMesh& >() ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: use of undeclared identifier 'pybind11' [clang-diagnostic-error]
.def( pybind11::init< const SurfaceMesh& >() )
^
@@ -37,11 +37,8 @@ namespace geode | |||
absl::StrCat( "SurfaceMeshAdjacency", dimension, "D" ); | |||
pybind11::class_< SurfaceMeshAdjacency >( module, name.c_str() ) | |||
.def( pybind11::init< const SurfaceMesh& >() ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: expected expression [clang-diagnostic-error]
.def( pybind11::init< const SurfaceMesh& >() )
^
#include <geode/inspector/criterion/brep_meshes_inspector.h> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: included header brep_meshes_inspector.h is not used directly [misc-include-cleaner]
#include <geode/inspector/criterion/brep_meshes_inspector.h> |
@@ -25,16 +25,42 @@ | |||
|
|||
#include <geode/inspector/brep_inspector.h> | |||
|
|||
#include <geode/inspector/criterion/brep_meshes_inspector.h> | |||
|
|||
namespace geode | |||
{ | |||
void define_brep_inspector( pybind11::module& module ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: use of undeclared identifier 'pybind11' [clang-diagnostic-error]
void define_brep_inspector( pybind11::module& module )
^
|
||
namespace geode | ||
{ | ||
void define_models_meshes_colocation( pybind11::module& module ) | ||
{ | ||
pybind11::class_< MeshesColocationInspectionResult >( | ||
module, "MeshesColocationInspectionResult" ) | ||
.def( pybind11::init<>() ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: use of undeclared identifier 'pybind11' [clang-diagnostic-error]
.def( pybind11::init<>() )
^
|
||
namespace geode | ||
{ | ||
void define_models_meshes_colocation( pybind11::module& module ) | ||
{ | ||
pybind11::class_< MeshesColocationInspectionResult >( | ||
module, "MeshesColocationInspectionResult" ) | ||
.def( pybind11::init<>() ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: expected expression [clang-diagnostic-error]
.def( pybind11::init<>() )
^
|
||
namespace geode | ||
{ | ||
void define_models_meshes_colocation( pybind11::module& module ) | ||
{ | ||
pybind11::class_< MeshesColocationInspectionResult >( | ||
module, "MeshesColocationInspectionResult" ) | ||
.def( pybind11::init<>() ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: expected expression [clang-diagnostic-error]
.def( pybind11::init<>() )
^
.def_readwrite( "colocated_points_groups", | ||
&MeshesColocationInspectionResult::colocated_points_groups ) | ||
.def( "string", &MeshesColocationInspectionResult::string ); | ||
|
||
PYTHON_COMPONENTS_COLOCATION( Section, Section ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: expected expression [clang-diagnostic-error]
PYTHON_COMPONENTS_COLOCATION( Section, Section );
^
Additional context
bindings/python/src/inspector/colocation/component_meshes_colocation.h:33: expanded from macro 'PYTHON_COMPONENTS_COLOCATION'
.def( pybind11::init< const type& >() ) \
^
.def_readwrite( "colocated_points_groups", | ||
&MeshesColocationInspectionResult::colocated_points_groups ) | ||
.def( "string", &MeshesColocationInspectionResult::string ); | ||
|
||
PYTHON_COMPONENTS_COLOCATION( Section, Section ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: unexpected type name 'SectionComponentMeshesColocation': expected expression [clang-diagnostic-error]
PYTHON_COMPONENTS_COLOCATION( Section, Section );
^
expanded from here
🎉 This PR is included in version 5.0.0-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 5.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.